Added monitor_port and monitor_address to lb_members_v2 #1363
Conversation
|
Build failed.
|
|
Build failed.
|
|
There seems to be an issue in the devstack-gate project as there is a dependecy chain (zuul -> devstack-gate -> script -> ara -> markup -> jinja2) that is broken somewhere near the end which causes the acceptance-tests to fail. I created an issue with the devstack-gate project here: https://storyboard.openstack.org/#!/story/2009973 |
|
Build failed.
|
|
recheck lbaas |
|
Build failed.
|
|
Needs to be tested after fixing #1366 |
|
@flashjmp can you rebase? There is an octavia job atm for testing changes |
flashjmp
force-pushed
the
fix-monitor-address-port
branch
from
44696c5
to
1be871e
Compare
@nikParasyr: Done... |
|
Hi there, |
|
@nikParasyr or @ozerovandrei , could your please review and merge? Thx ! |
There was a problem hiding this comment.
Hello. Could you fix the indentations?
Moreover the tests are skipped due to some unnecessary check. I'm removing it on #1412. So if you could wait for it to be merged and then rebase that would be great.
Other than that it looks good. Thank you
flashjmp
force-pushed
the
fix-monitor-address-port
branch
from
d599c84
to
382b28d
Compare
|
@nikParasyr : I fixed the indentations and rebased after the merging of #1412 ... could you pls trigger the workflows ? thx |
…orm-provider-openstack into fix-monitor-address-port
There was a problem hiding this comment.
@flashjmp This is good. I only have a minor thing i want to doublecheck. Thank you for all the work and patience. Hopefully next ones will fly faster :)
|
@nikParasyr could you merge then pls? |
Added the missing arguments for monitor_address and monitor_port to the lb_members_v2 resource.
This should fix my issue #1360