Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set missing 'docker_volume_size' parameter while reading 'openstack_containerinfra_nodegroup_v1' resource #1437

Merged
merged 1 commit into from Sep 5, 2022
Merged

Set missing 'docker_volume_size' parameter while reading 'openstack_containerinfra_nodegroup_v1' resource #1437

merged 1 commit into from Sep 5, 2022

Conversation

pawcykca
Copy link
Contributor

@pawcykca pawcykca commented Sep 5, 2022

Fix nodegroup recreation after import due missing 'docker_volume_size' parameter while reading 'openstack_containerinfra_nodegroup_v1' resource.

nikParasyr
nikParasyr approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@nikParasyr nikParasyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawcykca thanks for the fix. This looks good to me.

This is a simple change so i can merge it, i've seen your other PRs but im hoping to get the magnum ci to work because they are a bit bigger changes and i actually want to test them (see #1406 ).

Once again, thanks :)

@nikParasyr nikParasyr merged commit ae0a74e into terraform-provider-openstack:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikParasyr nikParasyr nikParasyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pawcykca @nikParasyr