Allow settings tags for lb_listener_v2 #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikParasyr
reviewed
Sep 6, 2022
| @@ -218,6 +221,85 @@ func testAccCheckLBV2ListenerExists(n string, listener *listeners.Listener) reso | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * gophercloud doesn't return the tags in the structure. Need to fix tghis first. | |||
There was a problem hiding this comment.
Hello,
From what i can see gophercloud supports tags in the return struct, this was added: gophercloud/gophercloud#2214
And we are using a version that includes this
There was a problem hiding this comment.
You are right, it should be there. But somehow it's failing and I don't know what's wrong.
Error: found.Tags undefined (type *"github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/lbaas_v2/listeners".Listener has no field or method Tags) (typecheck)
There was a problem hiding this comment.
@stinnux check my comment below
nikParasyr
reviewed
Sep 6, 2022
| return fmt.Errorf("Error creating OpenStack load balancing client: %s", err) | ||
| } | ||
|
|
||
| found, err := listeners.Get(lbClient, rs.Primary.ID).Extract() |
kayrus
force-pushed
the
octavia-tags-listener
branch
from
0e15366
to
3302594
Compare
|
@stinnux I rebased your branch to re-run tests. |
kayrus
force-pushed
the
octavia-tags-listener
branch
2 times, most recently
from
2fca8a0
to
6669659
Compare
kayrus
force-pushed
the
octavia-tags-listener
branch
from
6669659
to
fc75eb4
Compare
nikParasyr
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting tags for listener when using octavia.
The change is heavily "inspired" by the tag feature used in the loadbalancer resource and therefore uses the same approach.