Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing a list of tags in data_source_openstack_images_image_ids_v2 #1468

Conversation

rossengeorgiev
Copy link
Contributor

Ports change from #1462 for openstack_images_image_ids_v2
Fixes #1467

Allows filtering using a list a tags by setting the tags attribute, while maintaining backwards compatibility with tag attribute.

Original Syntax

data "openstack_images_image_ids_v2" "image_1" {
  tag   = "cirros-tf_1"
}

New Syntax with tags attribute

data "openstack_images_image_ids_v2" "image_1" {
  tags = ["cirros-tf_1"]
}

New Syntax using both tag and tags attribute

data "openstack_images_image_ids_v2" "image_1" {
  tag   = "cirros-tf_1"
  tags = ["cirros-tf_1"]
}

@rossengeorgiev rossengeorgiev changed the title Allow providing a list of tags in openstack_images_image_ids_v2 Allow providing a list of tags in data_source_openstack_images_image_ids_v2 Dec 22, 2022
Copy link
Member

@nikParasyr nikParasyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you

@nikParasyr nikParasyr merged commit c38a5ce into terraform-provider-openstack:main Dec 22, 2022
@rossengeorgiev
Copy link
Contributor Author

@nikParasyr thanks. Stupid question, how do build and use the provider locally?

@nikParasyr
Copy link
Member

@nikParasyr thanks. Stupid question, how do build and use the provider locally?

this comment should be helpful => #1428 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] data.openstack_images_image allow a list of tags to be provided
2 participants