Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name_regex attribute to data_source_openstack_images_image_v2 #1469

Conversation

rossengeorgiev
Copy link
Contributor

Noticed that data_source_openstack_images_image_ids_v2 has name_regex to filter images, while data_source_openstack_images_image_v2 doesn't. This PR adds it, and works in the same way.

Before:

Exact name matching only

data "openstack_images_image_ids_v2" "images" {
  name = "Ubuntu_16.04_cloudimage_amd64"
 }

After:

Partial name matching possible

data "openstack_images_image_ids_v2" "images" {
  name_regex = "^Ubuntu_16\\.04.*_amd64$"
 }

@rossengeorgiev rossengeorgiev force-pushed the add-name_regex-to-data_source_image branch from 6aeba98 to a226927 Compare December 25, 2022 09:52
Copy link
Collaborator

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kayrus kayrus merged commit d87624e into terraform-provider-openstack:main Feb 16, 2023
@kayrus kayrus mentioned this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants