Swift v1: add support for new object versioning #1498
Conversation
kayrus
force-pushed
the
container-versioning
branch
from
bb75902
to
abfa55b
Compare
kayrus
force-pushed
the
container-versioning
branch
from
abfa55b
to
d53dc0e
Compare
|
@ozerovandrei please review. |
There was a problem hiding this comment.
This is still a breaking change right?
The stateUpgrader will "move" what was on versioning to versioning_legacy but the user will still have to update his resource definition.
Or did i misunderstood something?
Moreover for some reason the tests are being skipped:
2023-02-28T20:52:42.1952225Z === RUN TestAccObjectStorageV1Container_versioning
2023-02-28T20:52:42.1953883Z 2023-02-28T20:52:42.195Z [DEBUG] sdk.helper_resource: Starting TestCase: test_name=TestAccObjectStorageV1Container_versioning
2023-02-28T20:52:42.1954805Z 2023-02-28T20:52:42.195Z [DEBUG] sdk.helper_resource: Calling TestCase PreCheck: test_name=TestAccObjectStorageV1Container_versioning
2023-02-28T20:52:42.1955825Z provider_test.go:270: this is not supported below stable/ussuri, testing in
2023-02-28T20:52:42.1956481Z --- SKIP: TestAccObjectStorageV1Container_versioning (0.00s)
2023-02-28T20:52:42.1958238Z PASS
Ill try to find some time to see why
correct. I think this is the most optimal solution.
hm... you're right... |
There was a problem hiding this comment.
Ok. tests seem to be running now and passing:
2023-03-01T07:25:46.8268716Z 2023-03-01T07:25:46.820Z [DEBUG] sdk.helper_resource: Called TestCase CheckDestroy: test_name=TestAccObjectStorageV1Container_versioning test_terraform_path=/tmp/plugintest-terraform3968591059/terraform test_working_directory=/tmp/plugintest195555014 test_step_number=1
2023-03-01T07:25:46.8269514Z 2023-03-01T07:25:46.820Z [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccObjectStorageV1Container_versioning
2023-03-01T07:25:46.8333324Z --- PASS: TestAccObjectStorageV1Container_versioning (3.15s)
I'll create an issue to have a look at why the testAccSkipReleasesBelow was not working as expected.
LGTM as long as we are ok with the breaking change (i do think as well thats it's the best way forward). Would like @ozerovandrei opinion as well
Fixes #1489