Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network v2]: Add support for network segments update and import #1508

Merged
merged 1 commit into from Mar 11, 2023
Merged

[network v2]: Add support for network segments update and import #1508

merged 1 commit into from Mar 11, 2023

Conversation

kayrus
Copy link
Collaborator

@kayrus kayrus commented Mar 5, 2023

Fixes #1477

@kayrus kayrus force-pushed the update-segments branch 2 times, most recently from 68b49fe to 223c0e7 Compare March 9, 2023 14:50
@kayrus kayrus marked this pull request as ready for review March 9, 2023 14:50
@kayrus kayrus force-pushed the update-segments branch 4 times, most recently from 616eb9d to 9c94798 Compare March 9, 2023 21:27
nikParasyr
nikParasyr requested changes Mar 10, 2023
View reviewed changes
Copy link
Member

@nikParasyr nikParasyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayrus Just some doc updates. Other than that LGTM

openstack/data_source_openstack_networking_network_v2.go Show resolved Hide resolved
openstack/resource_openstack_networking_network_v2.go Show resolved Hide resolved
@kayrus kayrus requested a review from nikParasyr March 10, 2023 13:52
@nikParasyr nikParasyr merged commit be5b194 into terraform-provider-openstack:main Mar 11, 2023
@kayrus kayrus deleted the update-segments branch March 11, 2023 09:40
@gc-nathanh gc-nathanh mentioned this pull request May 2, 2023
Closed
@kayrus kayrus mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikParasyr nikParasyr nikParasyr approved these changes

@ozerovandrei ozerovandrei Awaiting requested review from ozerovandrei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing configurations after importing openstack networks
2 participants
@kayrus @nikParasyr