fix(containerinfra): replace nodegroup if cluster_id changes #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cluster attached to a node group changed, that node group cannot be "re-attached", it should just be fully rebuilt.
|
@mnaser has this been tested or just based on docs? cause unfortunately we dont have a ci for magnum |
|
@nikParasyr I did not test it, no, sorry, I can try to find sometime to validate this. |
nikParasyr
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cluster attached to a node group changed, that node group
cannot be "re-attached", it should just be fully rebuilt.