Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new identity_inherit_role_assignment_v3 resource #1567

Merged

Conversation

nikParasyr
Copy link
Member

@nikParasyr nikParasyr commented May 21, 2023

This creates new identity resource for inherited roles using the OS-INHERIT keystone API. Chose to create a new resource instead of adding this functionality to existing role assignment to:

  • keep the resources clean and easy
  • this is a seperate api, thus i prefer a new resource to manage it
  • adding it to existing assignment would require updating the resource id and could impact users

Close #1372

@nikParasyr nikParasyr force-pushed the os-inherit branch 3 times, most recently from b05bb91 to d7610d3 Compare May 21, 2023 11:21
This creates new identity resource for inherited roles using
the OS-INHERIT keystone API. Chose to create a new resource instead
of adding this functionality to existing role assignment to:
- keep the resources clean and easy
- this is a seperate api, thus i prefer a new resource to manage it
- adding it to existing assignment would require updating the resource id
  and could impact users
Copy link
Collaborator

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The only drawbacks I see are duplicate code and documentation. The risk of human error is quite high, especially when someone makes a fix to a similar piece of code, as the duplicate part tends to be overlooked. In terms of code, this doesn't seem to be a major issue, as we can create additional functions that share the logic. However, when it comes to documentation, the only solution seems to be automatic documentation generation based on the source code. I believe we are not yet prepared to implement the autodocs, so I approve the PR.

@nikParasyr nikParasyr merged commit b5277d5 into terraform-provider-openstack:main Jun 1, 2023
7 checks passed
@nikParasyr nikParasyr deleted the os-inherit branch June 1, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inheritable role assignment using OS-INHERIT Identity API extension
2 participants