Add FWaaS_V2 #1577
Add FWaaS_V2 #1577
Conversation
Add functional-fwaas_v2 worflow. Exclude FWaaS_V2 tests from networking ACCEPTANCE_TESTS_FILTER. Add fw_group_v2 data source, resource, import, acc tests. Add fw_policy_v2 data source, resource, import, acc tests. Add fw_rule_v2 data source, resource, import, acc tests. Add FWaaS_V2 resource and data sources to DataSourcesMap. Add FWaaS_V2 website docs. Add FWaaS_V2 to openstack.erb. Bump Gophercloud version to 1.4.0. Update go.sum.
|
@Koodt Thanks for this. This is a huge PR (which should have been broken down in multiple PRs). I will have time to review it in a couple of weeks |
|
@Koodt This will be hard to review and also not a big fan of adding such a big change in one commit. would it be possible for you to break this into multiple PRs? One PR per resource. So each PR:
1st PR should include the CI definition. I will be able to review them after the 19th |
|
Groups and policies was removed |
There was a problem hiding this comment.
@Koodt Great PR!
I made some comments about things to fix. Most of them are "nit"/easy to do. Let me know if you need any clarifications somewhere
There was a problem hiding this comment.
@Koodt thanks you for this PR and all the work. Also for the patience for the reviews.
This looks good to me.
You can create the rest of the PRs for the fw_v2 resources (incorporate the feedback from this PR please -- such as ValidateFunc etc). I think there should be 2 resources and 2 data_sources left. so you can create 1 PR for each one of them ( 4 in total ), and ill try to review them as soon as possible and I think ill make a release after they merged ( together with a couple PRs that are already open)
nikParasyr
merged commit 4aa7691
into
terraform-provider-openstack:main
Hi there!
Add FWaaS_V2
Close 1/3 part of #115
Add functional-fwaas_v2 workflow.
Add fw_rule_v2 data source, resource, import, acc tests.
Add fw_rule_v2 resource and data sources to DataSourcesMap.
Add fw_rule_v2 website docs.
Add fw_rule_v2 to openstack.erb.
Bump Gophercloud version to 1.4.0.
Update go.sum.