Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glance v2]: add support for xz image decompression #1579

Merged
merged 4 commits into from Jun 22, 2023
Merged

[glance v2]: add support for xz image decompression #1579

merged 4 commits into from Jun 22, 2023

Conversation

kayrus
Copy link
Collaborator

@kayrus kayrus commented Jun 7, 2023 •
edited

Resolves #1578
Resolves #1343

@kayrus kayrus requested a review from nikParasyr June 20, 2023 14:56
@kayrus
Copy link
Collaborator Author

kayrus commented Jun 21, 2023 •
edited

@nikParasyr any objections on this PR?

There is one feature request from #1343 (comment) that I'd like to implement independently:

With image from http source, its tricky, but there needs to be hash field that I can set with the hash I expect. I would then like the provider to check the source file, and the upload file, against that hash. This allows me to use internet images, and rely on a strong hash to ensure I'm not getting a different image

@nikParasyr
Copy link
Collaborator

@nikParasyr any objections on this PR?

Haven't had time to look into it. will have tomorrow

@kayrus kayrus mentioned this pull request Jun 21, 2023
Closed
nikParasyr
nikParasyr approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@nikParasyr nikParasyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kayrus kayrus merged commit ae41960 into terraform-provider-openstack:main Jun 22, 2023
7 checks passed
@kayrus kayrus deleted the glance-xz branch June 22, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikParasyr nikParasyr nikParasyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xz image decompress support Downloading image from URL results in 0 bytes images or error (TLS cert expired)
2 participants
@kayrus @nikParasyr