[manila v2]: introduce a new share access rules read method #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikParasyr
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
@kayrus LGTM. you need to rebase due to conflict. But i cna merge after you do
kayrus
force-pushed
the
manila-list-access-rules
branch
from
3011544
to
a9f5d21
Compare
kayrus
force-pushed
the
manila-list-access-rules
branch
from
a9f5d21
to
4c30f01
Compare
|
@nikParasyr I noticed that POST method was used in the access rules refresh func. I reworked the PR with a cleaner code. |
nikParasyr
approved these changes
Jun 20, 2023
nikParasyr
merged commit 1d6c2a8
into
terraform-provider-openstack:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1582