Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] azurerm_redis_cache backup requires connection string #6819

Merged
merged 3 commits into from May 7, 2020

Conversation

cemckenzie
Copy link
Contributor

@cemckenzie cemckenzie commented May 7, 2020

When creating a redis-cache resource, the rdb-storage-connection-string in the redis_configuration is required is rdb_backup_enabled is true.

Currently, an error is thrown during the create:

redis.Client#Create: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidRequestBody" Message="The value of the parameter 'properties.redisConfiguration.rdb-storage-connection-string' is invalid."

This change updates the error to:

Error: Error parsing Redis Configuration: The rdb_storage_connection_string property must be set when rdb_backup_enabled is true on <PATH>/main.tf line 23

It also updates the docs.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @cemckenzie ! aside from 2 comments this looks good

website/docs/r/redis_cache.html.markdown Outdated Show resolved Hide resolved
@cemckenzie cemckenzie force-pushed the redis-backup-connection branch 2 times, most recently from 698ed80 to e0f9ba7 Compare May 7, 2020 21:20
@katbyte katbyte added this to the v2.9.0 milestone May 7, 2020
@katbyte katbyte added the bug label May 7, 2020
@cemckenzie cemckenzie requested a review from katbyte May 7, 2020 22:58
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cemckenzie! LGTM 👍

@katbyte katbyte merged commit 4b4a54e into hashicorp:master May 7, 2020
katbyte added a commit that referenced this pull request May 7, 2020
@cemckenzie cemckenzie deleted the redis-backup-connection branch May 7, 2020 23:33
@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants