New Resource: azurerm_eventgrid_domain_topic
#6859
Conversation
ghost
added
jrauschenbusch
changed the title
jrauschenbusch
changed the title
azurerm_eventgrid_domain_topic
jrauschenbusch
changed the title
azurerm_eventgrid_domain_topicazurerm_eventgrid_domain_topic
There was a problem hiding this comment.
hey @jrauschenbusch
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the minor comments then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/eventgrid/tests/eventgrid_domain_topic_resource_test.go
Outdated
Show resolved
Hide resolved
…ource.go fix: add `ForceNew` to enforce recreation if domain_name changes Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
There was a problem hiding this comment.
hey @jrauschenbusch
Thanks for pushing those changes - taking a look through it appears that Travis found a few minor issues with the "ForceNew" change - since this otherwise LGTM I hope you don't mind but I'm going to push a commit to resolve the outstanding comments so that we can get this merged 👍
Thanks!
azurerm/internal/services/eventgrid/eventgrid_domain_topic_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventgrid/eventgrid_domain_topic_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventgrid/eventgrid_domain_topic_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventgrid/tests/eventgrid_domain_topic_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventgrid/tests/eventgrid_domain_topic_resource_test.go
Outdated
Show resolved
Hide resolved
…ic_resource_test.go
|
This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.10.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Adds new resource
azurerm_eventgrid_domain_topicFixes #4097