Update azurerm_eventgrid_* resources #5948

jrauschenbusch · 2020-03-01T23:29:26Z

List of changes:

Updates clients to EventGrid API version 2020-01-01-preview
Adds resource azurerm_eventgrid_topic_domain
Additions to resource azurerm_eventgrid_topic:
- input_schema
- input_mapping_fields
- input_mapping_default_values
Additions to resource azurerm_eventgrid_event_subscription:
- service_bus_queue_endpoint
- azure_function_endpoint
- expiration_time_utc
- advanced_filters

Fixes #3452
Fixes #4097
Fixes #4308
Fixes #4857

jrauschenbusch · 2020-03-03T19:30:56Z

@tombuildsstuff I think this MR should now be in a reviewable state

jrauschenbusch · 2020-03-16T08:58:36Z

@mbfrahry @tombuildsstuff @tracypholmes Anyone who could review this? I know it's really a huge PR, but it was necessary to update the API client to be able to use the most up to date EventGrid features.

jrauschenbusch · 2020-04-08T05:57:10Z

@tombuildsstuff any update here?

CraftyFella · 2020-04-19T11:55:10Z

I for one would also like to know what's happening here too.. this would help out my scripts if it could be merged. Anything I can do to help?

#5948 (comment)

jrauschenbusch · 2020-04-22T12:02:21Z

@tombuildsstuff Is there a way to get some progress here? Are there any tests missing? There is already a new EventGrid API version available... and it contains a lot of new stuff. Imho we should try to get more closer to the azure-sdk-for-go release cycles to be able to use the newest features.

bkanzki

the advanced filter still doesn't work in terraform 1.12 with provider version 2.0

jrauschenbusch

First try to get some progress here with an initial self review.

azurerm/internal/services/eventgrid/resource_arm_eventgrid_event_subscription.go

jrauschenbusch · 2020-04-26T08:45:28Z

the advanced filter still doesn't work in terraform 1.12 with provider version 2.0

@jokerbea Can you give me a bit more details on this?

What was your test setup? TF 0.12 and TF AzureRM Provider 2.0**? Can you post your used TF files files? What was your expectation about the result? What went wrong from your point of view?

** Hint: For local testing you'd have to clone the forked AzureRM provider repo and build the latest state of the branch locally using the Makefile. Then you have to initialize your terraform project with the locally build terraform plugin by copying the compiled plugin to path ~/.terraform.d/plugins and use terraform init inside your project path. (Precondition would be an pre-installed and configured Go SDK)

mkdir -p ~/go/src/github.com/terraform-providers  && cd $_

git clone git@github.com:jrauschenbusch/terraform-provider-azurerm.git
cd terraform-provider-azurerm
make build

cp ~/go/bin/terraform-provider-azurerm ~/.terraform.d/plugins/terraform-provider-azurerm_v2.0.0

cd /path/to/your/tf/project
terraform init

bkanzki · 2020-04-27T13:14:33Z

Hello Jochen I'm trying to add the advanced filters to the subscriptions events with terraform. The attached file shows my actual code. As mentioned by you that parameter is not available yet. What I'm trying to do is: Have the advanced filters with the following parameters: - key: data.url Operator: String contains Value: /<folder>/<source_name>/ - key: data.api Operator: String is in Value: CreateFile Would there be any workaround for this with the present version of terraform to enable this. Le dim. 26 avr. 2020 à 04:45, Jochen Rauschenbusch <notifications@github.com> a écrit :

…

the advanced filter still doesn't work in terraform 1.12 with provider version 2.0 Can you give me a bit more details on this? What was your test setup? What was your expetation about the result? What went wrong from your point of view? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://mailtrack.io/trace/link/bb230d6ab0cadaef24de933c845c897e7bdf4a7c?url=https%3A%2F%2Fgithub.com%2Fterraform-providers%2Fterraform-provider-azurerm%2Fpull%2F5948%23issuecomment-619511188&userId=2464481&signature=9081ea360ca6db56>, or unsubscribe <https://mailtrack.io/trace/link/c581fb0f321b1a0a47e32cc55f047ed6e45d4685?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC6E7W54HSHUCOTROT73C43ROPYDHANCNFSM4K7JOAQQ&userId=2464481&signature=855f83eb0def2516> .

-- *Beatriz Kanzki* Bsc Bioinformatics MscA Software Engineering Specialized in Big Data analytics and cloud technologies ᐧ

- advanced_filter usage simplified - advanced_filter validation rules added - service_bus_topic_endpoint added - azure_function_endpoint added

jrauschenbusch · 2020-05-06T13:18:12Z

What I'm trying to do is:

Have the advanced filters with the following parameters:

key: data.url Operator: String contains Value: //<source_name>/

key: data.api Operator: String is in Value: CreateFile

Would there be any workaround for this with the present version of terraform to enable this.

@jokerbea As within the current AzureRM provider version only a subject filter is provided, this is currently not possible (see https://www.terraform.io/docs/providers/azurerm/r/eventgrid_event_subscription.html). Hence you have to wait until this PR is merged...

jrauschenbusch · 2020-05-06T14:13:27Z

@tombuildsstuff @tracypholmes @mbfrahry @katbyte @jackofallops Please assign a milestone label to this ticket so that it's on your roadmap. I've done a lot invested a lot of time to bring this topic forward.

katbyte

Hey @jrauschenbusch, thanks for this PR! However typically we try not to combine so many changes into one PR. Could you split this out into an SDK upgrade PR and then the rest of the changes into a couple different PRs? Large PRs like this take far longer to review and merge thus are more likely to sit in the qeue for a while. Thanks!

katbyte · 2020-05-06T21:12:50Z

azurerm/internal/services/eventgrid/resource_arm_eventgrid_domain_topic.go

+	id, err := azure.ParseAzureResourceID(d.Id())
+	if err != nil {
+		return err
+	}
+	resourceGroup := id.ResourceGroup
+	domainName := id.Path["domains"]
+	name := id.Path["topics"]


Could we write a specific parse function & use it like can be seen in #5356

katbyte · 2020-05-06T21:15:05Z

azurerm/internal/services/eventgrid/resource_arm_eventgrid_event_subscription.go

+}
+
+// RemoveFromStringArray removes all matching values from a string array
+func RemoveFromStringArray(elements []string, remove string) []string {


Could we move this to the utils package?

Hey @jrauschenbusch, thanks for this PR! However typically we try not to combine so many changes into one PR. Could you split this out into an SDK upgrade PR and then the rest of the changes into a couple different PRs? Large PRs like this take far longer to review and merge thus are more likely to sit in the qeue for a while. Thanks!

@katbyte Thanks for your response. I already had this feeling that the PR is ways too large. I try to split up the PR into multiple smaller ones.

My proposal:

PR for Basic Event Grid API Update to the latest Preview version (https://github.com/Azure/azure-sdk-for-go/tree/master/services/preview/eventgrid/mgmt/2020-04-01-preview/eventgrid)

PR for SDK util functions

PR for new resource azurerm_eventgrid_topic_domain

PR for extended resource azurerm_eventgrid_topic

PR for extended resource azurerm_eventgrid_event_subscription

Dedicated PR for advanced_filters in resource azurerm_eventgrid_event_subscription

You can attach the util functions into the first PR requiring them but otherwise sounds good!

@katbyte

Upgrade EventGrid SDK to 2020-04-01-preview from 2018-09-15-preview to address @katbyte comments in PR #5948.

jrauschenbusch · 2020-05-12T05:31:03Z

@katbyte I think we can close this PR in favor of the following more specific PRs:

@katbyte

Upgrade EventGrid SDK to 2020-04-01-preview from 2018-09-15-preview to address @katbyte comments in PR hashicorp#5948.

katbyte · 2020-05-14T00:00:34Z

Thanks! closing in favour of them

ghost · 2020-06-13T14:53:43Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

ghost added size/XXL dependencies documentation labels Mar 1, 2020

tombuildsstuff added service/event-grid EventGrid enhancement new-resource labels Mar 19, 2020

tombuildsstuff self-requested a review March 19, 2020 12:34

bkanzki reviewed Apr 23, 2020

View reviewed changes

jrauschenbusch commented Apr 26, 2020

View reviewed changes

jrauschenbusch added 4 commits May 6, 2020 14:45

Update: r/eventgrid_*

f305c0b

fixing tflint and lintrest violations

a9f12ae

Refactoring of azurerm_eventgrid_event_subscription resource

65259c9

- advanced_filter usage simplified - advanced_filter validation rules added - service_bus_topic_endpoint added - azure_function_endpoint added

fix: review notes

74a64a1

jrauschenbusch force-pushed the eventgrid-resources branch from d341d87 to 74a64a1 Compare May 6, 2020 12:48

fix: adapt to nested variable structure

1478ff1

jrauschenbusch added 2 commits May 6, 2020 16:02

fix: depscheck

4966c78

fix: lintrest

13213ee

katbyte requested changes May 6, 2020

View reviewed changes

jrauschenbusch mentioned this pull request May 9, 2020

Upgrade EventGrid SDK to 2020-04-01-preview #6837

Merged

katbyte pushed a commit that referenced this pull request May 11, 2020

Upgrade EventGrid SDK to 2020-04-01-preview (#6837)

0a635d7

Upgrade EventGrid SDK to 2020-04-01-preview from 2018-09-15-preview to address @katbyte comments in PR #5948.

katbyte closed this May 14, 2020

hashicorp locked and limited conversation to collaborators Jun 13, 2020

jrauschenbusch deleted the eventgrid-resources branch July 9, 2020 05:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update azurerm_eventgrid_* resources #5948

Update azurerm_eventgrid_* resources #5948

jrauschenbusch commented Mar 1, 2020 •

edited

jrauschenbusch commented Mar 3, 2020

jrauschenbusch commented Mar 16, 2020 •

edited

jrauschenbusch commented Apr 8, 2020

CraftyFella commented Apr 19, 2020

jrauschenbusch commented Apr 22, 2020 •

edited

bkanzki left a comment

jrauschenbusch left a comment

jrauschenbusch commented Apr 26, 2020 •

edited

bkanzki commented Apr 27, 2020 via email

jrauschenbusch commented May 6, 2020 •

edited

jrauschenbusch commented May 6, 2020 •

edited

katbyte left a comment

katbyte May 6, 2020

katbyte May 6, 2020

jrauschenbusch May 7, 2020

katbyte May 7, 2020

jrauschenbusch commented May 12, 2020

katbyte commented May 14, 2020

ghost commented Jun 13, 2020

Update azurerm_eventgrid_* resources #5948

Update azurerm_eventgrid_* resources #5948

Conversation

jrauschenbusch commented Mar 1, 2020 • edited

jrauschenbusch commented Mar 3, 2020

jrauschenbusch commented Mar 16, 2020 • edited

jrauschenbusch commented Apr 8, 2020

CraftyFella commented Apr 19, 2020

jrauschenbusch commented Apr 22, 2020 • edited

bkanzki left a comment

Choose a reason for hiding this comment

jrauschenbusch left a comment

Choose a reason for hiding this comment

jrauschenbusch commented Apr 26, 2020 • edited

bkanzki commented Apr 27, 2020 via email

jrauschenbusch commented May 6, 2020 • edited

jrauschenbusch commented May 6, 2020 • edited

katbyte left a comment

Choose a reason for hiding this comment

katbyte May 6, 2020

Choose a reason for hiding this comment

katbyte May 6, 2020

Choose a reason for hiding this comment

jrauschenbusch May 7, 2020

Choose a reason for hiding this comment

katbyte May 7, 2020

Choose a reason for hiding this comment

jrauschenbusch commented May 12, 2020

katbyte commented May 14, 2020

ghost commented Jun 13, 2020

jrauschenbusch commented Mar 1, 2020 •

edited

jrauschenbusch commented Mar 16, 2020 •

edited

jrauschenbusch commented Apr 22, 2020 •

edited

jrauschenbusch commented Apr 26, 2020 •

edited

jrauschenbusch commented May 6, 2020 •

edited

jrauschenbusch commented May 6, 2020 •

edited