Update Resource: azurerm_eventgrid_event_subscription

[jrauschenbusch]

Updates/extends resource azurerm_eventgrid_event_subscription

Additions to resource azurerm_eventgrid_event_subscription:

• service_bus_queue_endpoint
• service_bus_topic_endpoint
• expiration_time_utc

Fixes #4308
Fixes #4857

[katbyte]

Thanks for the PR @jrauschenbusch, overallt his looks good with just a couple comments. My main concern is that making each enpoint a block with a single property, while matching the API, doesn't offer and ideal UX and adds complexity to the code. Do you think it would make sense to flatten that out a bit as describe in my comment?

[jrauschenbusch]

@katbyte Can you please review may latest update (Deprecations / ConflictsWith / Constants / Fixes in ExpirationTime expanding / flattening)?

[katbyte]

Thanks @jrauschenbusch! aside from some minor comments on code style this is looking pretty good now 🙂

[jrauschenbusch]

@katbyte no worries 😄everything should be fixed now. plz check it out.

[katbyte]

Thanks for those changes @jrauschenbusch! Some tests where failing so i hope you don't mind but i pushed some fixes for them. Also it seems functions were not working:

 TestAccAzureRMEventGridEventSubscription_azureFunctionID: testing.go:640: Step 0 error: errors during apply:

        Error: Error creating/updating EventGrid Event Subscription "acctest-eg-200524142001966081" (Scope "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestRG-eg-200524142001966081"): eventgrid.EventSubscriptionsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidRequest" Message="Invalid ARM Id."

          on /var/folders/bc/2t9ylvbn4lj1_nzj7bxj2kzc0000gn/T/tf-test720774928/main.tf line 35:
          (source code not available)

and it seems like that one should be a block as there are other properties to set:

type AzureFunctionEventSubscriptionDestinationProperties struct {
	// ResourceID - The Azure Resource Id that represents the endpoint of the Azure Function destination of an event subscription.
	ResourceID *string `json:"resourceId,omitempty"`
	// MaxEventsPerBatch - Maximum number of events per batch.
	MaxEventsPerBatch *int32 `json:"maxEventsPerBatch,omitempty"`
	// PreferredBatchSizeInKilobytes - Preferred batch size in Kilobytes.
	PreferredBatchSizeInKilobytes *int32 `json:"preferredBatchSizeInKilobytes,omitempty"`
}

So i've removed it from this PR so we can get this merged and in for 2.12 - it can be added back in as a new PR.

[ghost]

This has been released in version 2.12.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.12.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!