Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_subscription get Primary/Secondary Key #6938

Merged
merged 11 commits into from May 20, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented May 15, 2020

Partially fixes issue #6795

While require_import fails, it needs breaking changes (subscription_id from optional to required)which I'd like to split it into another PR.
image

@ghost ghost added the size/XS label May 15, 2020
d.Set("state", string(props.State))
d.Set("product_id", props.Scope)
d.Set("user_id", props.OwnerID)
}

// Primary and secondary keys must be got from this additional api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this documented as a breaking change from Microsoft? Just curious how you figured this out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service team comment it in swagger

Copy link
Contributor

@tnicolaysen tnicolaysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straight forward change. 👍

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68! LGTM 👍

@katbyte katbyte modified the milestones: v2.12.0, v2.11.0 May 20, 2020
@katbyte katbyte merged commit e02bfeb into hashicorp:master May 20, 2020
katbyte added a commit that referenced this pull request May 20, 2020
@yupwei68 yupwei68 deleted the wyp-apim-subs branch May 20, 2020 01:52
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants