Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve time dimension parsing #1097

Merged
merged 2 commits into from Apr 13, 2023
Merged

Conversation

hblitza
Copy link
Contributor

@hblitza hblitza commented Apr 13, 2023

Description

Related issues or pull requests

This highly speeds up the parsing of time dimension information.
It took > 7sec for 5,000 timestamps, now < 1sec.

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I have added a screenshot/screencast to illustrate the visual output of my update.
  • I have added the proposed change to the CHANGELOG.md.
  • I have run the test suite successfully (run npm test locally).

Thanks for co-working @hwbllmnn
@terrestris/devs please review

@hblitza hblitza merged commit 6db21dd into master Apr 13, 2023
1 check passed
@hblitza hblitza deleted the improve-timedimension-parsing branch April 13, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants