Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace deprecated mockito-inline by mockito-core #682

Merged
merged 1 commit into from Apr 25, 2023
Merged

fix: replace deprecated mockito-inline by mockito-core #682

merged 1 commit into from Apr 25, 2023

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Apr 25, 2023

Description

See title. This fixes the failing tests of HttpProxyService

Plz review @terrestris/devs

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@ahennr
Copy link
Member Author

ahennr commented Apr 25, 2023

See e.g. mockito/mockito#2945 and mockito/mockito#2877

@ahennr ahennr merged commit 95fff11 into dependabot/maven/org.mockito-mockito-core-5.3.1 Apr 25, 2023
4 checks passed
@ahennr ahennr deleted the mockito branch April 25, 2023 08:07
@simonseyock
Copy link
Member

🎉 This PR is included in version 16.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlkoch dnlkoch dnlkoch approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahennr @simonseyock @dnlkoch