Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lizardmodified.py #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wjonessmd
Copy link

Lizard only does modified complexity for languages with switch/case structures (like Java). This change means modified complexity can also be done with languages that have case/when structures (like Ruby).

Lizard only does modified complexity for languages with switch/case structures (like Java). This change means modified complexity can also be done with languages that have case/when structures (like Ruby).
@terryyin
Copy link
Owner

terryyin commented Apr 4, 2022

Hi @wjonessmd , thanks for the pull request. I'm sorry that I cannot accept it as is. If it's ok and you are interested I have the following comments:

  1. Given the way you write the code, at least 10 new test cases are required (by CCN). I believe 2 or 3 new test cases should be enough, but you have to write code without so much duplicates.
  2. We do need new test cases for new logic
  3. Try not to use changing variables
  4. If you have to use changing variables, try to limit it's scope
  5. Try not to compare boolean with True or False

I'm looking forward to your updates:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants