Update clean-css To v5.3
#150
Conversation
|
When are you planning to merge this pull request, we are unable to use "html-minimizer-webpack-plugin" because of transitive dependency of "clean-css" using older version. |
|
@sibiraj-s can you handle the release of a new version? That would be great. @RamyaKVelivala for a short-term solution please take a look at yarn resolutions and npm overrides: |
|
Thanks @DanielRuf Hi. These changes are now part of v7.2.0. Thanks for the contribution @Casey-Kiewit . I’ve been having minor problems at my end hence the delay. I’ll try to keep up henceforth. |
| @@ -75,7 +75,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "camel-case": "^4.1.2", | |||
| "clean-css": "5.2.0", | |||
| "clean-css": "~5.3.2", | |||
There was a problem hiding this comment.
You really should have used ^ here so that when 5.4.x etc is out no one needs to change the package here.
There was a problem hiding this comment.
I can fix it in coming releases.
There was a problem hiding this comment.
There was a problem hiding this comment.
Well, if they offer to update the deps in a timely manner, sure. Otherwise, better use ^ and when tests break, someone updates the fixtures. That was the consumers won't have to wait for a new html-minifier-terser release.
Both solutions are a compromise, of course; it depends from which point of view one sees the issue. :)
There was a problem hiding this comment.
Yes, I didn’t want to use ~ or ^ in case of clean-css, just pin to a fixed version. since they introduced a breaking change in semver minor. But if it a one time thing like an accident or a bug fix actually. May be we can ignore this once.
As this might allow less maintenance releases from our end, also allows users to stay upto date on security patches.
I am fine on both options have a caret or pin it. But if clean-css doesn’t follow semver or this happened more than once, I recommend pin it.
There was a problem hiding this comment.
Yeah, semver is hard to follow, I've been there myself 😛
Thanks for considering!
Updates
clean-cssto the latest version. Updates a test to reflect the functionally identical but different output the latest version ofclean-cssproduces.Resolves #149.