Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests compatible with Node.js 12 and prerelease versions #197

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Make tests compatible with Node.js 12 and prerelease versions #197

merged 3 commits into from
Dec 19, 2018

Commits on Dec 16, 2018

  1. make version check work with prerelease versions 

    semver.satisfies does not match a prerelease version against a
non-prerelease one, e.g. 12.0.0-pre does not match >= 10. Use a regex
match to workaround this fact.
    @silverwind
    silverwind committed Dec 16, 2018
    Configuration menu
    Copy the full SHA
    cb5d974 View commit details
    Browse the repository at this point in the history

  2. make tests compatible with Node.js 12 

    In Node.js 12, the formatting of console arguments will change slightly.
Previously, a string other than the first argument was formatted using
single quotes if the first argument was non-string. Now, quotes are
never added regardless of position of a string argument.

To make test compatible in all Node.js versions, I work around by
ensuring the first argument to console.log is a string which prevents
the quotes from being added on older versions of Node.js.

Ref: nodejs/node#23162
    @silverwind
    silverwind committed Dec 16, 2018
    Configuration menu
    Copy the full SHA
    00de155 View commit details
    Browse the repository at this point in the history

  3. restart travis

    @silverwind
    silverwind committed Dec 16, 2018
    Configuration menu
    Copy the full SHA
    08ca958 View commit details
    Browse the repository at this point in the history