Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CONTRIBUTING file #539

Merged
merged 2 commits into from Oct 3, 2022

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It copies the CONTRIBUTING.md file from tc-java, locating it in the root dir of the project.

Why is it important?

Two things: 1) it provides context on how to contribute to the project, and 2) helps with the onboarding process for Hacktoberfest

@mdelapenya mdelapenya requested a review from a team as a code owner September 29, 2022 14:01
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Sep 29, 2022
@mdelapenya mdelapenya self-assigned this Sep 29, 2022
@mdelapenya mdelapenya requested a review from a team September 29, 2022 14:01
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #539 (7491304) into main (6ee7f6a) will decrease coverage by 0.14%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   68.85%   68.70%   -0.15%     
==========================================
  Files          22       22              
  Lines        2148     2154       +6     
==========================================
+ Hits         1479     1480       +1     
- Misses        530      535       +5     
  Partials      139      139              
Impacted Files Coverage Δ
wait/sql.go 22.22% <0.00%> (-0.86%) ⬇️
wait/host_port.go 47.47% <40.00%> (-0.95%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CONTRIBUTING.md Show resolved Hide resolved
docs/bounty.md Show resolved Hide resolved
@mdelapenya mdelapenya merged commit e6cdf54 into testcontainers:main Oct 3, 2022
@mdelapenya mdelapenya deleted the add-contributing-file branch October 3, 2022 16:08
@mdelapenya mdelapenya mentioned this pull request Oct 22, 2022
mdelapenya referenced this pull request in mdelapenya/testcontainers-go Dec 21, 2022
* main:
  Add system requirements parent docs page for podman and colima (#562)
  Support for cap-add/cap-drop (#555)
  fix container NetworkMode usage (#560)
  chore: use hashed versions of test-summary action (#556)
  chore: use container.State() function in tests (#543)
  Log docker server info (#548)
  docs: add docs regarding Colima usage (#547)
  chore: add emoji to breaking changes in release drafter (#542)
  chore: add CONTRIBUTING file (#539)
  issue #537 Rename the wait/multi.go file to wait/all.go (#541)
  docs: add a basic layout for wait strategies in docs (#536)
  docs: improve consistency and fix typos (#534)
  chore: do not skip test (#528)
  chore: include test flakiness in the release drafter (#535)
  chore: retire old versions of Go (#530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants