chore: prepare for 0.15.0 release #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
===========================================
+ Coverage 15.40% 33.37% +17.96%
===========================================
Files 13 13
Lines 1759 1759
===========================================
+ Hits 271 587 +316
+ Misses 1442 1087 -355
- Partials 46 85 +39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mdelapenya
commented
Oct 24, 2022
| @@ -60,4 +60,4 @@ nav: | |||
| - Getting help: getting_help.md | |||
| edit_uri: edit/main/docs/ | |||
| extra: | |||
| latest_version: 0.14.0 | |||
| latest_version: 0.15.0 | |||
There was a problem hiding this comment.
I've double checked that this value is not affecting the web UI
mdelapenya
commented
Oct 24, 2022
| @@ -12,7 +12,7 @@ import ( | |||
| const defaultForSqlQuery = "SELECT 1" | |||
|
|
|||
| //ForSQL constructs a new waitForSql strategy for the given driver | |||
| func ForSQL(port nat.Port, driver string, url func(string, nat.Port) string) *waitForSql { | |||
| func ForSQL(port nat.Port, driver string, url func(host string, port nat.Port) string) *waitForSql { | |||
There was a problem hiding this comment.
I'm adding this cosmetic change here, but I can send it in a separate PR if needed
|
Merging as the change is harmless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It bumps the version of the library in the docs site, and adds named parameters in a function of the public API.
Why is it important?
Keep docs up-to-date, and increase the readability of that function while consuming it.