Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare for 0.15.0 release #581

Merged
merged 2 commits into from Oct 24, 2022
Merged

chore: prepare for 0.15.0 release #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cb6789
chore: bump version in docs
mdelapenya Oct 24, 2022
2b1f81a
chore: named parameters
mdelapenya Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion mkdocs.yml
View file
Open in desktop
Expand Up @@ -60,4 +60,4 @@ nav:
- Getting help: getting_help.md
edit_uri: edit/main/docs/
extra:
latest_version: 0.14.0
latest_version: 0.15.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've double checked that this value is not affecting the web UI

Screenshot 2022-10-24 at 11 34 42

2 changes: 1 addition & 1 deletion wait/sql.go
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@ import (
const defaultForSqlQuery = "SELECT 1"

//ForSQL constructs a new waitForSql strategy for the given driver
func ForSQL(port nat.Port, driver string, url func(string, nat.Port) string) *waitForSql {
func ForSQL(port nat.Port, driver string, url func(host string, port nat.Port) string) *waitForSql {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding this cosmetic change here, but I can send it in a separate PR if needed

return &waitForSql{
Port: port,
URL: url,
Expand Down