Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modules.kafka): Use broker container IP instead of host IP for advertised broker listener #1989

Merged
merged 10 commits into from May 8, 2024
Merged

fix(modules.kafka): Use broker container IP instead of host IP for advertised broker listener #1989

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ba9ada0
Fix advertised broker ip
khartld Dec 8, 2023
683284a
Merge branch 'main' into patch-1
mdelapenya Jan 31, 2024
05aadac
Merge branch 'main' into patch-1
mdelapenya Feb 14, 2024
abdb1cd
Merge branch 'main' into patch-1
mdelapenya Mar 5, 2024
9abe5a1
Merge branch 'main' into patch-1
khartld Mar 15, 2024
4dd9ff7
Merge branch 'main' into patch-1
khartld Apr 2, 2024
459e58d
Add fn to fetch the hostname
eddumelendez Apr 5, 2024
d86e692
Merge branch 'main' into patch-1
mdelapenya May 7, 2024
c38bbc1
chore: use the new Inspect method instead
mdelapenya May 7, 2024
f4991ba
chore: add test
mdelapenya May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/kafka/kafka.go
View file
Open in desktop
Expand Up @@ -72,12 +72,17 @@ func RunContainer(ctx context.Context, opts ...testcontainers.ContainerCustomize
return err
}

ip, err := c.ContainerIP(ctx)
khartld marked this conversation as resolved.
Show resolved Hide resolved
if err != nil {
return err
}

port, err := c.MappedPort(ctx, publicPort)
if err != nil {
return err
}

scriptContent := fmt.Sprintf(starterScriptContent, host, port.Int(), host)
scriptContent := fmt.Sprintf(starterScriptContent, host, port.Int(), ip)

return c.CopyToContainer(ctx, []byte(scriptContent), starterScript, 0o755)
},
Expand Down