Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the file and mounts tests into a test package #2270

Conversation

Minivera
Copy link
Contributor

What does this PR do?

This work has been extracted from #2202 and is related to #2180. See the original PR for the full context and reasoning.

Why is it important?

This will help with the documentation, since all examples will now have the module prefixes.

Related issues

This work has been extracted from testcontainers#2202 and is related to testcontainers#2180. See the original PR for the full context and reasoning.

This will help with the documentation, since all examples will now have the module prefixes.
@Minivera Minivera requested a review from a team as a code owner February 28, 2024 21:06
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit adbd264
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65e0ec77c7b51b0008281e4a
😎 Deploy Preview https://deploy-preview-2270--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This initially LGTM, just a comment regarding a file name, not a blocker

utils_test.go Outdated Show resolved Hide resolved
@mdelapenya mdelapenya self-assigned this Mar 1, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Mar 1, 2024
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit 38550a6 into testcontainers:main Mar 1, 2024
91 checks passed
mdelapenya added a commit to jespino/testcontainers-go that referenced this pull request Mar 1, 2024
* main:
  chore: bump Go version to 1.21 (testcontainers#2292)
  chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (testcontainers#2226)
  feat: WithLogger ContainerCustomizer support (testcontainers#2259)
  chore(deps): bump github.com/jackc/pgx/v5 in /modules/cockroachdb (testcontainers#2217)
  Move the file and mounts tests into a test package (testcontainers#2270)
  Fix Dockerfile not located when added to dockerignore (testcontainers#2272)
@Minivera Minivera deleted the gui/move-files-mounts-test-to-test-package branch March 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants