Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition when looking up reaper (ryuk) container #2508

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix race condition when looking up reaper (ryuk) container #2508

wants to merge 4 commits into from
+36 −0

Commits on May 21, 2024

  1. If the ryuk container has a health status, wait for a healthy contain… 

    …er before returning.
    @emetsger
    emetsger committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4fee0d9 View commit details
    Browse the repository at this point in the history

  2. Use docker/types for health status, but also check for the zero value.

    @emetsger
    emetsger committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b097968 View commit details
    Browse the repository at this point in the history

  3. Wait for the ryuk port to be available in case the container is still… 

    … being started by newReaper in a separate process.

A race between newReaper and lookUpReaperContainer occurs:
- newReaper creates the container with a ContainerRequest.WaitingFor = wait.ForListeningPort(listeningPort)
- newReaper starts the container
- lookUpReaperContainer obtains the container and returns.
- newReaper invokes the readiness hook wait.ForListeningPort(listeningPort).
    @emetsger
    emetsger committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0c99285 View commit details
    Browse the repository at this point in the history

  4. Fix whitespace.

    @emetsger
    emetsger committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f92db6e View commit details
    Browse the repository at this point in the history