Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose terminateContainerOnEnd as Cleanup #616

Closed
wants to merge 3 commits into from
Closed

feat: expose terminateContainerOnEnd as Cleanup #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
408bb7a
feat: expose terminateContainerOnEnd as Cleanup
hhsnopek Nov 8, 2022
5adabb6
fix: remove unnecessary Cleanup call
hhsnopek Nov 10, 2022
4595efa
Merge branch 'main' into cleanup
mdelapenya Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions container_test.go
View file
Open in desktop
Expand Up @@ -324,7 +324,7 @@ func Test_BuildImageWithContexts(t *testing.T) {
} else if err != nil {
t.Fatal(err)
} else {
terminateContainerOnEnd(t, ctx, c)
Cleanup(t, ctx, c)
}
})
}
Expand All @@ -346,7 +346,7 @@ func Test_GetLogsFromFailedContainer(t *testing.T) {
if err != nil && !errors.Is(err, context.DeadlineExceeded) {
t.Fatal(err)
} else if err == nil {
terminateContainerOnEnd(t, ctx, c)
Cleanup(t, ctx, c)
t.Fatal("was expecting error starting container")
}

Expand Down Expand Up @@ -396,7 +396,7 @@ func createTestContainer(t *testing.T, ctx context.Context) int {
t.Fatalf("could not get mapped port: %v", err)
}

terminateContainerOnEnd(t, ctx, container)
Cleanup(t, ctx, container)

return port.Int()
}
Expand Down