Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MySQL module #943

Merged
merged 14 commits into from Mar 23, 2023
Merged

Add MySQL module #943

merged 14 commits into from Mar 23, 2023

Conversation

eddumelendez
Copy link
Member

The module allow to start a MySQL database. By default, the value
for username, password and database is test but those can be
set using the proper functions WithUsername(), WithPassword and
WithDatabase(). It also provides fns to get those values and
build the connection string.

@eddumelendez
Add MySQL module
26cb828 
The module allow to start a MySQL database. By default, the value
for username, password and database is test but those can be
set using the proper functions `WithUsername()`, `WithPassword` and
`WithDatabase()`. It also provides fns to get those values and
build the connection string.
@netlify
Copy link

netlify bot commented Mar 18, 2023 •
edited

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 4fab6c6
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/641c8010b9cec40008567e59
😎 Deploy Preview https://deploy-preview-943--testcontainers-go.netlify.app/modules/mysql
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mdelapenya
mdelapenya reviewed Mar 20, 2023
View reviewed changes
modules/mysql/mysql.go Outdated Show resolved Hide resolved
@mdelapenya mdelapenya mentioned this pull request Mar 20, 2023
Open
48 tasks
@mdelapenya mdelapenya self-assigned this Mar 21, 2023
@mdelapenya mdelapenya added the enhancement New feature or request label Mar 21, 2023
@eddumelendez eddumelendez marked this pull request as ready for review March 21, 2023 18:09
@eddumelendez eddumelendez requested a review from a team as a code owner March 21, 2023 18:09
mdelapenya
mdelapenya reviewed Mar 23, 2023
View reviewed changes
modules/mysql/mysql.go Outdated Show resolved Hide resolved
modules/mysql/mysql.go Outdated Show resolved Hide resolved
eddumelendez and others added 2 commits March 23, 2023 00:04
@eddumelendez @mdelapenya
Update modules/mysql/mysql.go
a1702ea 
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
@eddumelendez @mdelapenya
Update modules/mysql/mysql.go
01fc534 
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
mdelapenya reviewed Mar 23, 2023
View reviewed changes
modules/mysql/mysql.go Outdated Show resolved Hide resolved
mdelapenya
mdelapenya reviewed Mar 23, 2023
View reviewed changes
modules/mysql/mysql.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
19.6% 19.6% Duplication

mdelapenya
mdelapenya approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great module, as always!

@mdelapenya mdelapenya merged commit b98e0c9 into main Mar 23, 2023
95 checks passed
@mdelapenya mdelapenya deleted the mysql branch March 23, 2023 17:37
@mdelapenya mdelapenya mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddumelendez @mdelapenya