feat: add status check to wait strategies #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mdelapenya
reviewed
Mar 21, 2023
There was a problem hiding this comment.
@frozenbonito it LGTM, thanks for your contribution!
I added a few comments, minors, but wanted to check with you first before approving the PR.
frozenbonito
force-pushed
the
fails-wait-when-container-stops
branch
2 times, most recently
from
4900223
to
6c456ee
Compare
frozenbonito
force-pushed
the
fails-wait-when-container-stops
branch
from
6c456ee
to
1584e32
Compare
|
SonarCloud Quality Gate failed.
|
mdelapenya
reviewed
Mar 22, 2023
mdelapenya
approved these changes
Mar 22, 2023
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds container status check to wait strategies while polling.
Why is it important?
Some strategies assume the container is running.
However, a container may terminate due to an unexpected error, etc. Even in this case, testcontainers-go will keep waiting until the timeout.
This PR enables fail-fast when a container stops.
Related issues