Skip to content

Commit

Permalink
Remove unnecessary configuration from simple tests (#5973)
Browse files Browse the repository at this point in the history
* Remove mysql configuration from simple test
* mysql custom ini file test also runs on Windows

Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
  • Loading branch information
JanHendrikDolling and kiview committed Oct 4, 2022
1 parent b1fa4ec commit f5e79b9
Showing 1 changed file with 0 additions and 5 deletions.
@@ -1,6 +1,5 @@
package org.testcontainers.junit.mysql;

import org.apache.commons.lang3.SystemUtils;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -21,7 +20,6 @@

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
import static org.junit.Assume.assumeFalse;

public class SimpleMySQLTest extends AbstractContainerDatabaseTest {

Expand All @@ -48,7 +46,6 @@ public class SimpleMySQLTest extends AbstractContainerDatabaseTest {
public void testSimple() throws SQLException {
try (
MySQLContainer<?> mysql = new MySQLContainer<>(MySQLTestImages.MYSQL_57_IMAGE)
.withConfigurationOverride("somepath/mysql_conf_override")
.withLogConsumer(new Slf4jLogConsumer(logger))
) {
mysql.start();
Expand Down Expand Up @@ -81,8 +78,6 @@ public void testSpecificVersion() throws SQLException {

@Test
public void testMySQLWithCustomIniFile() throws SQLException {
assumeFalse(SystemUtils.IS_OS_WINDOWS);

try (
MySQLContainer<?> mysqlCustomConfig = new MySQLContainer<>(MySQLTestImages.MYSQL_56_IMAGE)
.withConfigurationOverride("somepath/mysql_conf_override")
Expand Down

0 comments on commit f5e79b9

Please sign in to comment.