Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary configuration from simple tests #5973

Merged
merged 3 commits into from Oct 4, 2022
Merged

Remove unnecessary configuration from simple tests #5973

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da2b7a6
chore: simple test with no configuration
JanHendrikDolling Oct 4, 2022
799fcc7
chore: mysql custom ini file test also runs on Windows
JanHendrikDolling Oct 4, 2022
4570605
Update modules/mysql/src/test/java/org/testcontainers/junit/mysql/Sim…
JanHendrikDolling Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions modules/mysql/src/test/java/org/testcontainers/junit/mysql/SimpleMySQLTest.java
View file
Open in desktop
@@ -1,6 +1,5 @@
package org.testcontainers.junit.mysql;

import org.apache.commons.lang3.SystemUtils;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -21,7 +20,6 @@

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
import static org.junit.Assume.assumeFalse;

public class SimpleMySQLTest extends AbstractContainerDatabaseTest {

Expand All @@ -48,7 +46,6 @@ public class SimpleMySQLTest extends AbstractContainerDatabaseTest {
public void testSimple() throws SQLException {
try (
MySQLContainer<?> mysql = new MySQLContainer<>(MySQLTestImages.MYSQL_57_IMAGE)
.withConfigurationOverride("somepath/mysql_conf_override")
.withLogConsumer(new Slf4jLogConsumer(logger))
) {
mysql.start();
Expand Down Expand Up @@ -81,8 +78,6 @@ public void testSpecificVersion() throws SQLException {

@Test
public void testMySQLWithCustomIniFile() throws SQLException {
assumeFalse(SystemUtils.IS_OS_WINDOWS);

try (
MySQLContainer<?> mysqlCustomConfig = new MySQLContainer<>(MySQLTestImages.MYSQL_56_IMAGE)
.withConfigurationOverride("somepath/mysql_conf_override")
Expand Down