Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface to customize CreateContainerCmd #7421
Add interface to customize CreateContainerCmd #7421
Changes from 1 commit
3a02788
873ef54
6c0c004
bd35a9b
540abdb
8bb2e10
f5b5125
02b14f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should think about either deprecating
withCreateContainerCmdModifier
or adding an overload, to avoid increasing the API surface. Maybe, as a first step, we could keepwithCreateContainerCmdModifier
only but make it populatelocalCreateContainerCustomizers
?Also, if we name it
CreateContainerCmdModifier
, then we could align both APIs and not have to deprecate the old one (just thinking out loud...) - WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like I forgot something when trying to overload
withCreateContainerCmdModifier
🙈. Now, this is done. My only question is about the location wherecreateContainerCmdCustomizers
is being called becausecreateContainerCmdModifiers
is currently called before.I think the current implementation is ok and we should dropcreateContainerCmdModifiers
references due to are not being used.