Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate withSecretInVault #7576

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Deprecate withSecretInVault #7576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/vault/src/main/java/org/testcontainers/vault/VaultContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ public SELF withLogLevel(VaultLogLevel level) {
* @param firstSecret first secret to add to specifed path
* @param remainingSecrets var args list of secrets to add to specified path
* @return this
* @deprecated use {@link #withInitCommand(String...)} instead
*/
@Deprecated
public SELF withSecretInVault(String path, String firstSecret, String... remainingSecrets) {
List<String> list = new ArrayList<>();
list.add(firstSecret);
Expand Down
16 changes: 6 additions & 10 deletions modules/vault/src/test/java/org/testcontainers/vault/VaultContainerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,12 @@ public class VaultContainerTest {
// vaultContainer {
public static VaultContainer<?> vaultContainer = new VaultContainer<>("hashicorp/vault:1.13")
.withVaultToken(VAULT_TOKEN)
.withSecretInVault("secret/testing1", "top_secret=password123")
.withSecretInVault(
"secret/testing2",
"secret_one=password1",
"secret_two=password2",
"secret_three=password3",
"secret_three=password3",
"secret_four=password4"
)
.withInitCommand("secrets enable transit", "write -f transit/keys/my-key");
.withInitCommand(
"secrets enable transit",
"write -f transit/keys/my-key",
"kv put secret/testing1 top_secret=password123",
"kv put secret/testing2 secret_one=password1 secret_two=password2 secret_three=password3 secret_three=password3 secret_four=password4"
);

// }

Expand Down