Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArangoDB Container support #221

Merged
merged 15 commits into from Jun 14, 2022
Merged

Conversation

nshine
Copy link
Contributor

@nshine nshine commented Jun 5, 2022

@thedrow
Copy link
Collaborator

thedrow commented Jun 6, 2022

Thanks!

Celery definitely needs this one for its integration suite.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #221 (07e829b) into master (df0c28a) will increase coverage by 0.36%.
The diff coverage is 100.00%.

❗ Current head 07e829b differs from pull request most recent head ce52b43. Consider uploading reports for the commit ce52b43 to get more accurate results

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   86.18%   86.54%   +0.36%     
==========================================
  Files          26       27       +1     
  Lines         702      721      +19     
  Branches       65       65              
==========================================
+ Hits          605      624      +19     
  Misses         76       76              
  Partials       21       21              
Impacted Files Coverage Δ
testcontainers/arangodb.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df0c28a...ce52b43. Read the comment docs.

@tillahoffmann
Copy link
Collaborator

The failing tests seem to be the consequence of a recent sphinx change (sphinx-doc/sphinx#10474). You should be able to fix it by changing language = None to language = 'en' in docs/conf.py.

@nshine
Copy link
Contributor Author

nshine commented Jun 6, 2022

Fixed

Copy link
Collaborator

@tillahoffmann tillahoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few small comments.

setup.py Outdated Show resolved Hide resolved
testcontainers/arangodb.py Outdated Show resolved Hide resolved
testcontainers/arangodb.py Outdated Show resolved Hide resolved
testcontainers/arangodb.py Outdated Show resolved Hide resolved
testcontainers/arangodb.py Outdated Show resolved Hide resolved
testcontainers/arangodb.py Outdated Show resolved Hide resolved
nshine and others added 5 commits June 6, 2022 22:34
Co-authored-by: Till Hoffmann <tillahoffmann@gmail.com>
Co-authored-by: Till Hoffmann <tillahoffmann@gmail.com>
Co-authored-by: Till Hoffmann <tillahoffmann@gmail.com>
Co-authored-by: Till Hoffmann <tillahoffmann@gmail.com>
@nshine nshine requested a review from tillahoffmann June 6, 2022 19:58
@nshine
Copy link
Contributor Author

nshine commented Jun 6, 2022

Thanks for your review. updated.

Copy link
Collaborator

@tillahoffmann tillahoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more thoughts.

testcontainers/arangodb.py Outdated Show resolved Hide resolved
testcontainers/arangodb.py Show resolved Hide resolved
@nshine nshine requested a review from tillahoffmann June 7, 2022 05:34
@nshine
Copy link
Contributor Author

nshine commented Jun 8, 2022

Hi, all resolved.

@nshine
Copy link
Contributor Author

nshine commented Jun 10, 2022

@tillahoffmann - I will appreciate if you could merge and generate a new release.

@nshine
Copy link
Contributor Author

nshine commented Jun 14, 2022

Hi @thedrow / @SergeyPirogov any chance you can step in and approve&release this one ?

@SergeyPirogov SergeyPirogov merged commit c0dc701 into testcontainers:master Jun 14, 2022
@SergeyPirogov
Copy link
Collaborator

@nshine thank you

@nshine
Copy link
Contributor Author

nshine commented Jun 14, 2022

Hi @SergeyPirogov
Thanks for the approve - can you please trigger a new release? i.e. 3.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants