New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ArangoDB Container support #221
Conversation
Thanks! Celery definitely needs this one for its integration suite. |
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
+ Coverage 86.18% 86.54% +0.36%
==========================================
Files 26 27 +1
Lines 702 721 +19
Branches 65 65
==========================================
+ Hits 605 624 +19
Misses 76 76
Partials 21 21
Continue to review full report at Codecov.
|
The failing tests seem to be the consequence of a recent sphinx change (sphinx-doc/sphinx#10474). You should be able to fix it by changing |
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A few small comments.
Co-authored-by: Till Hoffmann <tillahoffmann@gmail.com>
Co-authored-by: Till Hoffmann <tillahoffmann@gmail.com>
Co-authored-by: Till Hoffmann <tillahoffmann@gmail.com>
Co-authored-by: Till Hoffmann <tillahoffmann@gmail.com>
Thanks for your review. updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more thoughts.
Hi, all resolved. |
@tillahoffmann - I will appreciate if you could merge and generate a new release. |
Hi @thedrow / @SergeyPirogov any chance you can step in and approve&release this one ? |
@nshine thank you |
Hi @SergeyPirogov |
ArangoDB -> https://www.arangodb.com