Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make thenThrow and thenReject accept values of any type #511

Merged
merged 1 commit into from
Mar 28, 2023
Merged

make thenThrow and thenReject accept values of any type #511

merged 1 commit into from
Mar 28, 2023

Conversation

iliocatallo
Copy link
Contributor

Hello there,

In TypeScript, Promise.reject accepts a reason of type any.

Since thenReject is a short-hand for thenReturn(Promise.reject), the proposal here is to make thenReject accept a parameter of type any. The same applies for throw vs. thenThrow.

Ciao!

@searls searls merged commit 3c243bc into testdouble:main Mar 28, 2023
@searls
Copy link
Member

searls commented Mar 28, 2023 •
edited

Landed in v3.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iliocatallo @searls