Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1419 implement failed tests count in summary output #1420

Conversation

Mifrill
Copy link
Contributor

@Mifrill Mifrill commented Mar 13, 2021

closes #1419

@Mifrill Mifrill marked this pull request as ready for review March 13, 2021 08:02
@Mifrill
Copy link
Contributor Author

Mifrill commented Mar 13, 2021

locally the all tests passed with the integration tests, probably it's something not related to the current code changes

npm run integration
echo $?
=> 0

@johanneswuerbach
Copy link
Member

@Mifrill could you rebase your branch? The tests are fixed in the latest master.

@Mifrill Mifrill force-pushed the issue_1419/dot_reporter-show_counter_of_failed_tests_in_summary branch from 8844add to 95fc9b2 Compare March 15, 2021 11:42
@Mifrill
Copy link
Contributor Author

Mifrill commented Mar 15, 2021

is it better to probably use the same approach as for TapReporter?:

// testem/lib/reporters/tap_reporter.js
summaryDisplay() {
    let lines = [
      `1..${  this.total}`,
      `# tests ${  this.total}`,
      `# pass  ${  this.pass}`,
      `# skip  ${  this.skipped}`,
      `# fail  ${  this.total - this.pass - this.skipped}`
    ];

    if (this.pass + this.skipped === this.total) {
      lines.push('');
      lines.push('# ok');
    }

    return lines.join('\n');
  }

@johanneswuerbach
Copy link
Member

johanneswuerbach commented Mar 15, 2021

Yes, if you could do this change, it would probably be better to keep them consistent.

@Mifrill Mifrill force-pushed the issue_1419/dot_reporter-show_counter_of_failed_tests_in_summary branch from 4b92649 to 705290a Compare March 15, 2021 19:06
@Mifrill Mifrill force-pushed the issue_1419/dot_reporter-show_counter_of_failed_tests_in_summary branch from 705290a to e5bb8cc Compare March 15, 2021 19:10
@johanneswuerbach johanneswuerbach merged commit c95671d into testem:master Mar 15, 2021
@Mifrill Mifrill deleted the issue_1419/dot_reporter-show_counter_of_failed_tests_in_summary branch March 15, 2021 19:47
@Mifrill
Copy link
Contributor Author

Mifrill commented Mar 15, 2021

@johanneswuerbach thank you!

@johanneswuerbach
Copy link
Member

Released as https://github.com/testem/testem/releases/tag/v3.3.0, thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dot_reporter] Show counter of failed tests in summary
2 participants