skip testBasicSortTests in general #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please take a look at the merge conflicts; looks like it's just removing six at this point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding on our current Python3-specific disable: I'm also seeing this test fail randomly, in exactly the same way, on Python 2.7.15 (custom Linux 4.16.18). FWIW it seems to fail most commonly on 32-bit ARM (soft and hard float) and AArch64-ILP32; I have yet to see it fail on AArch64 or x86[-64].
Also, let's consistently use testtools skip decorators. We aren't even guaranteed to have unittest2 if we don't put it in the reqs, and other test code is already supposed to cope with this gracefully.