Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pypy tests in test_testresult.py #358

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 16, 2023

Fixes #333

Test both supported versions of PyPy3. https://www.pypy.org/download.html

:-(. Both fail in similar ways.

With two spaces less, pypy3.9 now passes but pypy3.10 fails.

With marker = '^^^' if sys.version_info >= (3, 10) else '^' everyone seems happy.

Perhaps add Py3.11, Py3.12, Pypy3.9, and Pypy3.10 to the Required tests below.

See #356 (comment) for the Some checks haven’t completed yet message below.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 17, 2023

@jelmer Why does the final test never run?

@jelmer
Copy link
Member

jelmer commented Oct 17, 2023

@jelmer Why does the final test never run?

Hmm, which one?

@cclauss
Copy link
Contributor Author

cclauss commented Oct 17, 2023

Now I see… build/pypy is required but that test is now renamed to build/pypy3.9 or build/pypy3.10 but the required list did not update with the rename. See #356 (comment) for the Some checks haven’t completed yet message below.

cclauss added a commit to cclauss/testtools that referenced this pull request Oct 18, 2023
@cclauss cclauss changed the title GitHub Actions: Test both pypy3.9 and pypy3.10 Fix pypy tests in test_testresult.py Oct 18, 2023
@jelmer
Copy link
Member

jelmer commented Oct 18, 2023

I've updated the list just now.

@jelmer jelmer merged commit aedd0cb into testing-cabal:master Oct 18, 2023
10 checks passed
@cclauss cclauss deleted the patch-2 branch October 18, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures with PyPy3.9
2 participants