fix: canSuggest should not be case sensitive (#628)

* test: add failing test * fix: compare lowecase methods
testing-library · Jun 13, 2020 · d6f6d3a · d6f6d3a
1 parent 30a1ee8
commit d6f6d3a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/__tests__/suggestions.js b/src/__tests__/suggestions.js
@@ -373,7 +373,9 @@ test('getSuggestedQuery can return specified methods in addition to the best', (
   const input = container.querySelector('input')
   const button = container.querySelector('button')
 
-  expect(getSuggestedQuery(input, 'get', 'Role')).toMatchObject({
+  // this function should be insensitive for the method param.
+  // Role and role should work the same
+  expect(getSuggestedQuery(input, 'get', 'role')).toMatchObject({
     queryName: 'Role',
     queryMethod: 'getByRole',
     queryArgs: ['textbox', {name: /label/i}],

diff --git a/src/suggestions.js b/src/suggestions.js
@@ -69,7 +69,11 @@ function makeSuggestion(queryName, content, {variant = 'get', name}) {
 }
 
 function canSuggest(currentMethod, requestedMethod, data) {
-  return data && (!requestedMethod || requestedMethod === currentMethod)
+  return (
+    data &&
+    (!requestedMethod ||
+      requestedMethod.toLowerCase() === currentMethod.toLowerCase())
+  )
 }
 
 export function getSuggestedQuery(element, variant, method) {