New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: canSuggest should not be case sensitive #628
fix: canSuggest should not be case sensitive #628
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2be6315:
|
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 565 565
Branches 142 141 -1
=========================================
Hits 565 565
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this 👍
@all-contributors please add @marcosvega91 for code and tests |
I've put up a pull request to add @marcosvega91! 🎉 |
🎉 This PR is included in version 7.14.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
It's not a big deal, but how are we going to support this when adding typescript support? 😇 type method = role | Role | getByText | getbytext | .... Seems unwanted to me. |
But in this case you will have an error so I think that we don't need to cover both cases in the type |
What:
Following up #627 I have updated
canSuggest
function because it only works when methods where exactly the same.Why:
because I think that
getSuggestedQuery
should return the same result for method 'Role' and method 'role'.How:
I have compared lowecase strings.
Checklist:
docs site