Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kcd-scripts to 12.x #1208

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 28, 2023

What:

Bump kcd-scripts to 12.x

Why:

Get newer versions of JSDOM

How:

Bump kcd-scripts to 12.x

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7efa04d:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #1208 (7efa04d) into alpha (c37ea2e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             alpha     #1208   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          998       998           
  Branches       327       327           
=========================================
  Hits           998       998           
Flag Coverage Δ
node-14 100.00% <100.00%> (ø)
node-16 100.00% <100.00%> (ø)
node-18 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers.ts 100.00% <ø> (ø)
src/query-helpers.ts 100.00% <ø> (ø)
src/screen.ts 100.00% <ø> (ø)
src/queries/label-text.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eps1lon eps1lon changed the title Bump kcd-scripts to 9.x Bump kcd-scripts to 12.x Jan 28, 2023
@eps1lon eps1lon marked this pull request as ready for review January 29, 2023 09:31
expect(console.error.mock.calls[0][0]).toMatch(
'Error: Not implemented: window.computedStyle(elt, pseudoElt)',
expect(console.error.mock.calls[0][0].message).toMatch(
'Not implemented: window.computedStyle(elt, pseudoElt)',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSDOM now calls console.error with the actual Error instance instead of its stringified version

@eps1lon eps1lon merged commit 6e2e864 into testing-library:alpha Jan 29, 2023
@eps1lon eps1lon deleted the test/kcd-scripts-bump branch January 29, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant