Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: 9.0.0 #1213

Merged
merged 6 commits into from
Feb 16, 2023
Merged

release: 9.0.0 #1213

merged 6 commits into from
Feb 16, 2023

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Feb 9, 2023 •
edited

Will be fast-forward merge on 16.02.2023 unless we need to revise some changes.

Tested latest alpha on the Klarna monorepo and this caught some bad queries assuming exact applied to the name option. But exact applies to the role. This is why these options were removed: they're misleading and most likely not needed.

9.0.0-alpha.2 (2023-02-09)

Bug Fixes

BREAKING CHANGES

  • ByRole: Only allow string as a role.
    Drop support for exact, trim, collapseWhitespace, and normalizer options.

9.0.0-alpha.1 (2023-01-29)

Features

BREAKING CHANGES

  • Minimum supported Node.js version is now 14.x

eps1lon and others added 6 commits January 29, 2023 10:30
@eps1lon
feat: Drop support for Node.js 12.x (#1207)
c37ea2e 
BREAKING CHANGE: Minimum supported Node.js version is now 14.x
@eps1lon
Bump kcd-scripts to 12.x (#1208)
6e2e864 
* Bump kcd-scripts to 9.x

* Fix lint issues

* fix lint
@eps1lon
Bump kcd-scripts to 13.0.0 (#1209)
25dc8a9 
* Bump kcd-scripts to 13.0.0

* Fix Jest warnings
@DaniAcu @eps1lon
chore: Migrate ByRole to TypeScript (#1186)
42809fe 
* fix: migrate role to ts

* fix: remove role model abstraction

* fix: prettier

* fix: force have role that are included in type

* fix: type

* fix: error and add commet ts

* fix: any type

* fix: any type

* fix: type assertion

* fix: ignore branch coverage

* fix: typo

* fix: add hints in all by role

* fix: types and comments

* fix: restore types

* fix: restore types

* fix: lint

* fix: ts error

* fix: ts error

* fix: type tests

* Fix lint

* Don't couple query-helpers with ByRole

* Revert change to ByRoleMatcher type

---------

Co-authored-by: eps1lon <silbermann.sebastian@gmail.com>
@allcontributors
docs: add DaniAcu as a contributor for code (#1212)
2d360a6 
* docs: update README.md

* docs: update .all-contributorsrc

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@eps1lon
fix(ByRole): Constrain API (#1211)
746def6 
BREAKING CHANGE: Only allow `string` as a `role`.
Drop support for `exact`, `trim`, `collapseWhitespace`, and `normalizer` options.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 746def6:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited

Codecov Report

Merging #1213 (746def6) into main (0ce0c70) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          998       992    -6     
  Branches       327       322    -5     
=========================================
- Hits           998       992    -6
Flag Coverage Δ
node-12 ?
node-14 100.00% <100.00%> (ø)
node-16 100.00% <100.00%> (ø)
node-18 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers.ts 100.00% <ø> (ø)
src/query-helpers.ts 100.00% <ø> (ø)
src/screen.ts 100.00% <ø> (ø)
src/queries/label-text.ts 100.00% <100.00%> (ø)
src/queries/role.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eps1lon eps1lon changed the title release: 13.0.0 release: 9.0.0 Feb 9, 2023
@eps1lon eps1lon marked this pull request as ready for review February 9, 2023 15:50
timdeschryver
timdeschryver approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my codebase without breaking change 🚀

@eps1lon
Copy link
Member Author

eps1lon commented Feb 11, 2023

Small update: It did catch some breaking changes during type-checking. Specifically, we had a bunch of queries using exact: false. It looks like it was assumed exact applies to name not role considering that removing the option did not break runtime tests. If it was intended (e.g. including role="spinbutton") then I'm ok with this breaking change. People should make it explicit what roles they expect instead of relying on perfect knowledge of all possible roles (which is especially problematic since new roles can be added to ARIA).

@eps1lon eps1lon merged commit 746def6 into main Feb 16, 2023
@eps1lon eps1lon deleted the alpha branch February 16, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eps1lon @timdeschryver @DaniAcu