Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add reactStrictMode for react-testing-library #1256

Closed
wants to merge 1 commit into from

Conversation

yinm
Copy link

@yinm yinm commented Sep 7, 2023

What:

Add reactStrictMode to config for react-testing-library

Why:

ref: testing-library/react-testing-library#338 (comment)

To support default reactStrictMode configuration

( @eps1lon If I misunderstand, please tell me 馃檹 )

How:

I added reactStrictMode to config in this PR.
Next, I will create PR in react-testing-library. It enables StrictMode render by using reactStrictMode configuration.

Checklist:

  • Documentation added to the N/A
    docs site
  • Tests N/A
  • TypeScript definitions updated
  • Ready to be merged

@eps1lon
Copy link
Member

eps1lon commented Sep 16, 2023

This option should be added to https://github.com/testing-library/react-testing-library instead

@eps1lon eps1lon closed this Sep 16, 2023
@yinm yinm deleted the feat/reactStrictMode branch September 23, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants