Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix coverage #382

Merged
merged 1 commit into from Oct 13, 2019
Merged

test: fix coverage #382

merged 1 commit into from Oct 13, 2019

Conversation

kentcdodds
Copy link
Member

What: fix coverage

Why: I merged #381 without realizing that it didn't have 100% coverage. Now it wont be released. Unless I'm mistaken, we don't need to have coverage on that else branch because it's temporary code anyway.

How: add istabul ignore comment

Checklist:

@kentcdodds kentcdodds merged commit 500ffdf into master Oct 13, 2019
@kentcdodds kentcdodds deleted the pr/fix-coverage branch October 13, 2019 16:52
@kentcdodds
Copy link
Member Author

cc @eps1lon, if this is incorrect and you can think of a test case we could write to get coverage on this, then feel free to add that. Thanks!

@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 6.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eps1lon
Copy link
Member

eps1lon commented Oct 13, 2019

cc @eps1lon, if this is incorrect and you can think of a test case we could write to get coverage on this, then feel free to add that. Thanks!

That particular bug is going to be fixed soon (PR has been approved and is waiting for merge+release). I'd rather remove this code altogether once it's fixed in jsdom.

@eps1lon
Copy link
Member

eps1lon commented Oct 14, 2019

Actually it's blocked by jest. jestjs/jest#8851 needs to be released (scheduled for v25) in order to get jsdom@^15.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants