Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prettyRoles): crash in older browsers #464

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 4, 2020

What:

Fixes crash when logging roles in older browsers (namely IE11)

Why:

Objec.entries is not implemented in older browsers

How:

Use Object.keys

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] I've prepared a PR for types targeting
    DefinitelyTyped
  • Tests (Testing codesandbox canary on Material-UI)
  • Ready to be merged

@eps1lon eps1lon added the bug Something isn't working label Mar 4, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1d55f4:

Sandbox Source
priceless-brown-ob38x Configuration

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #464 into beta will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              beta      #464   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          419       420    +1     
  Branches       100       100           
=========================================
+ Hits           419       420    +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6d90f...d1d55f4. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

@kentcdodds kentcdodds merged commit 46cbcda into testing-library:beta Mar 4, 2020
@eps1lon eps1lon deleted the fix/object-entries branch March 4, 2020 23:09
@eps1lon
Copy link
Member Author

eps1lon commented Mar 4, 2020

Requires a bit more work (jestjs/jest#9635) but doesn't hurt to get this in anyway. At least this way I can hopefully fall back to pretty-format@24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants