Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fake-timers): raf is now mocked in legacy fake timers #986

Merged
merged 1 commit into from Jun 23, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 23, 2021

What:

Fix tests.

Why:

To be able to release

How:

Normalize requestAnimationFrame related tests across legacy and modern timers after jestjs/jest#11567 was released

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34c52b0:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #986 (34c52b0) into main (13efbb3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #986   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        25    -1     
  Lines          962       914   -48     
  Branches       290       281    -9     
=========================================
- Hits           962       914   -48     
Flag Coverage Δ
node-10.14.2 ?
node-12 100.00% <100.00%> (ø)
node-14 100.00% <100.00%> (ø)
node-15 ?
node-16 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/role-helpers.js 100.00% <ø> (ø)
src/suggestions.js 100.00% <ø> (ø)
src/config.ts 100.00% <100.00%> (ø)
src/event-map.js 100.00% <100.00%> (ø)
src/get-user-code-frame.js 100.00% <100.00%> (ø)
src/helpers.js 100.00% <100.00%> (ø)
src/pretty-dom.js 100.00% <100.00%> (ø)
src/queries/role.js 100.00% <100.00%> (ø)
src/queries/text.ts 100.00% <100.00%> (ø)
src/queries/title.ts 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d347302...34c52b0. Read the comment docs.

@eps1lon eps1lon marked this pull request as ready for review June 23, 2021 06:17
@eps1lon eps1lon merged commit 84ebc51 into testing-library:main Jun 23, 2021
@eps1lon eps1lon deleted the test/updated-jest branch June 23, 2021 06:17
@github-actions
Copy link

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant