Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't test with node 10 #201

Merged
merged 1 commit into from Sep 20, 2021
Merged

chore: Don't test with node 10 #201

merged 1 commit into from Sep 20, 2021

Conversation

nickmccurdy
Copy link
Member

@nickmccurdy nickmccurdy commented Sep 20, 2021

Reopening #181 on the main branch because ESLint 8 has dropped node 10 support as of August 5th (eslint/eslint#14023).

What: Don't test with node 10

Why: Node 10 reached EOL on July 30th so let's free up some CI resources.

How: Remove 10 from node test matrix.

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • Ready to be merged

@nickmccurdy
Copy link
Member Author

Does merging this depend on #190?

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #201 (c92a998) into main (a5fc94f) will not change coverage.
The diff coverage is n/a.

❗ Current head c92a998 differs from pull request most recent head 228c39d. Consider uploading reports for the commit 228c39d to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          555       555           
  Branches       152       152           
=========================================
  Hits           555       555           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5fc94f...228c39d. Read the comment docs.

@benmonro benmonro merged commit 9cf6351 into main Sep 20, 2021
@benmonro benmonro deleted the nickmccurdy-patch-1 branch September 20, 2021 02:44
@MichaelDeBoey
Copy link
Member

@benmonro I would have kept Node 10 tests until ESLint v8 support was merged (as that drops it) just to be in line with ESLint, but not really a big deal

@nickmccurdy
Copy link
Member Author

Yea Node 10 support has been officially dropped anyway, so if there was an issue in Node, ESLint may not be able to work around it

@github-actions
Copy link

🎉 This PR is included in version 3.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants