test: 100% coverage (#53)

testing-library · Dec 10, 2019 · 2b7c731 · 2b7c731
1 parent 7b8c2c6
commit 2b7c731
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/lib/rules/prefer-explicit-assert.js b/lib/rules/prefer-explicit-assert.js
@@ -6,7 +6,7 @@ const ALL_GET_BY_QUERIES = ALL_QUERIES_METHODS.map(
   queryMethod => `get${queryMethod}`
 );
 
-const isValidQuery = (node, customQueryNames = []) =>
+const isValidQuery = (node, customQueryNames) =>
   ALL_GET_BY_QUERIES.includes(node.name) ||
   customQueryNames.includes(node.name);
 

diff --git a/lib/utils.js b/lib/utils.js
@@ -48,18 +48,7 @@ const ALL_QUERIES_COMBINATIONS = [
   ASYNC_QUERIES_COMBINATIONS,
 ];
 
-const findParent = (node, cb) => {
-  if (cb(node)) {
-    return node;
-  } else if (node.parent) {
-    return findParent(node.parent, cb);
-  }
-
-  return null;
-};
-
 module.exports = {
-  findParent,
   getDocsUrl,
   SYNC_QUERIES_VARIANTS,
   ASYNC_QUERIES_VARIANTS,

diff --git a/tests/lib/rules/prefer-explicit-assert.js b/tests/lib/rules/prefer-explicit-assert.js
@@ -68,6 +68,9 @@ ruleTester.run('prefer-explicit-assert', rule, {
     {
       code: `const a = { foo: getByText('bar') }`,
     },
+    {
+      code: `queryByText("foo")`,
+    },
   ],
 
   invalid: [
@@ -111,6 +114,16 @@ ruleTester.run('prefer-explicit-assert', rule, {
         },
       ],
     })),
+    // for coverage
+    {
+      code: `getByText("foo")`,
+      options: [{ foo: 'bar' }],
+      errors: [
+        {
+          messageId: 'preferExplicitAssert',
+        },
+      ],
+    },
     {
       code: `getByIcon('foo')`, // custom `getBy` query extended through options
       options: [